New lint: Require # Safety section in pub unsafe fn docs
#4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
requested changes
Sep 12, 2019
flip1995
added
the
S-waiting-on-author
llogiq
force-pushed
the
unsafe-doc
branch
5 times, most recently
from
692fea2
to
6b6bdb8
Compare
|
Thanks for the review! r? @flip1995 |
flip1995
reviewed
Sep 13, 2019
phansch
reviewed
Sep 13, 2019
| pub unsafe fn apocalypse(universe: &mut ()) { | ||
| unimplemented!(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Could you also add a test that the lint doesn't trigger on non-async functions?
There was a problem hiding this comment.
You mean an async function? How would that work?
There was a problem hiding this comment.
ah sorry, I meant adding a test for a non-unsafe function :D
|
Thanks again, @flip1995 |
flip1995
approved these changes
Sep 16, 2019
|
Thanks! @bors r+ |
|
📌 Commit 38f252a has been approved by |
bors
added a commit
that referenced
this pull request
Sep 16, 2019
New lint: Require `# Safety` section in pub unsafe fn docs changelog: add `missing_safety_doc` lint This fixes #2207
|
💔 Test failed - checks-travis |
|
@bors rollup |
|
@bors r+ |
|
📌 Commit 70a7dab has been approved by |
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Sep 19, 2019
New lint: Require `# Safety` section in pub unsafe fn docs changelog: add `missing_safety_doc` lint This fixes rust-lang#2207
bors
added a commit
that referenced
this pull request
Sep 19, 2019
Rollup of 4 pull requests Successful merges: - #4511 (New lint: mem_replace_with_uninit) - #4535 (New lint: Require `# Safety` section in pub unsafe fn docs) - #4539 (Changes cast-lossless to a pedantic lint) - #4544 (#4542 remove machine applicable suggestion) Failed merges: r? @ghost changelog: none
bors
added a commit
that referenced
this pull request
Sep 19, 2019
New lint: Require `# Safety` section in pub unsafe fn docs changelog: add `missing_safety_doc` lint This fixes #2207
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: add
missing_safety_doclintThis fixes #2207